summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Down <chris@chrisdown.name>2022-04-26 09:42:23 +0100
committerHiltjo Posthuma <hiltjo@codemadness.org>2022-04-26 15:50:55 +0200
commit8b48e309735f5fe49d35f86e967f4b5dea2a2f2d (patch)
treec6ddd25fd19323b6d14599024d744fcb23f59ef5
parenta83dc2031050d786ddf5f329b57d658a931c94b7 (diff)
downloaddwm-8b48e309735f5fe49d35f86e967f4b5dea2a2f2d.tar.gz
dwm-8b48e309735f5fe49d35f86e967f4b5dea2a2f2d.zip
manage: Make sure c->isfixed is applied before floating checks
Commit 8806b6e23793 ("manage: propertynotify: Reduce cost of unused size hints") mistakenly removed an early size hints update that's needed to populate c->isfixed for floating checks at manage() time. This resulted in fixed (size hint min dimensions == max dimensions) subset of windows not floating when they should. See https://lists.suckless.org/dev/2204/34730.html for discussion.
-rw-r--r--dwm.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/dwm.c b/dwm.c
index 823bf6b..5646a5c 100644
--- a/dwm.c
+++ b/dwm.c
@@ -1061,6 +1061,7 @@ manage(Window w, XWindowAttributes *wa)
1061 XSetWindowBorder(dpy, w, scheme[SchemeNorm][ColBorder].pixel); 1061 XSetWindowBorder(dpy, w, scheme[SchemeNorm][ColBorder].pixel);
1062 configure(c); /* propagates border_width, if size doesn't change */ 1062 configure(c); /* propagates border_width, if size doesn't change */
1063 updatewindowtype(c); 1063 updatewindowtype(c);
1064 updatesizehints(c);
1064 updatewmhints(c); 1065 updatewmhints(c);
1065 XSelectInput(dpy, w, EnterWindowMask|FocusChangeMask|PropertyChangeMask|StructureNotifyMask); 1066 XSelectInput(dpy, w, EnterWindowMask|FocusChangeMask|PropertyChangeMask|StructureNotifyMask);
1066 grabbuttons(c, 0); 1067 grabbuttons(c, 0);